lazymio/unicorn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bindings: ruby: fix unexpected uc_query result pointer type (#1962)

Browse Source 
uc_query expects a size_t *, while we are passing uc_arch *. This has
been working for a while as gcc just warned about this, however with
latest gcc this changed into an error:

unicorn.c:122:34: error: passing argument 3 of ‘uc_query’ from incompatible pointer type [-Wincompatible-pointer-types]
  206 |     uc_query(_uc, UC_QUERY_ARCH, &arch);
unicorn.h:689:60: note: expected ‘size_t *’ {aka ‘long unsigned int *’} but argument is of type ‘uc_arch *’
  689 | uc_err uc_query(uc_engine *uc, uc_query_type type, size_t *result);

Fix this issue by querying the result into a size_t and later downcast
the result into an uc_arch enum.
This commit is contained in:
Levente Polyak
2025-04-05 00:05:43 +02:00
committed by GitHub
parent f59d5aa4bc
commit 1aad423fe5
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
bindings/ruby/unicorn_gem/ext/unicorn.c
View File

@@ -118,8 +118,9 @@ VALUE m_uc_reg_read(VALUE self, VALUE reg_id){
uc_engine *_uc;
Data_Get_Struct(rb_iv_get(self,"@uch"), uc_engine, _uc);
uc_arch arch;
uc_query(_uc, UC_QUERY_ARCH, &arch);
size_t arch_result;
uc_query(_uc, UC_QUERY_ARCH, &arch_result);
uc_arch arch = (uc_arch) arch_result;
if(arch == UC_ARCH_X86) {
switch(tmp_reg){
@@ -202,8 +203,9 @@ VALUE m_uc_reg_write(VALUE self, VALUE reg_id, VALUE reg_value){
uc_engine *_uc;
Data_Get_Struct(rb_iv_get(self,"@uch"), uc_engine, _uc);
uc_arch arch;
uc_query(_uc, UC_QUERY_ARCH, &arch);
size_t arch_result;
uc_query(_uc, UC_QUERY_ARCH, &arch_result);
uc_arch arch = (uc_arch) arch_result;
if(arch == UC_ARCH_X86) {
switch(tmp_reg){